-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update coc with include subject line #220
Conversation
I think "will" has an air of being reassuring in that "this will happen when you report". But I think the "will" then needs to be paired with a "you". So let's change it to say "We will follow up with you as a priority" or similar. |
6acf82b
to
e7dffac
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it but Erik should decide when and how to merge it.
In this context I believe follow up here acts as a phrasal verb rather than a compound noun. The compound noun takes a hyphen, but the phrasal verb does not. |
So, it depends on how important we feel this change is. We could merge this which would also fix the trailing whitespace on repos. There are also still open org-wide-files PRs that have not been merged. I can either:
I don't have particularly strong opinions on this. I think I'll prefer merging the existing PRs first. |
Ahh, nice resource! I appreciate the heads-up and source, I'll change it back. |
@iHiD Are you happy with this? |
Yep! :) |
chore: update coc with include subject line exercism/org-wide-files#220 .github/labels: remove trailing whitespace exercism/org-wide-files#216
chore: update coc with include subject line exercism/org-wide-files#220 .github/labels: remove trailing whitespace exercism/org-wide-files#216
chore: update coc with include subject line exercism/org-wide-files#220
I assume there's no need to update the copy in the root of the repository; I can see your bot takes care of that. 🤔
Happy with this?
I just have 2 questions:
Have a preference between these two?
I actually disagree with the use of the word "will" in this case. The word "will" usually denotes the willingness to do something, or the intent to do something in future. I assume you already take reports seriously and deal with CoC issues as a priority. The word "will" is out of place in my opinion.
In my opinion "We deal with all CoC issues as a priority." is much better. It states what you actually do rather than what you're willing to do, which may or may not be what do now. Thoughts on this?
On the other hand, I got an E in GCSE English so what do I know. 🥲
Related