Implement new Concept Exercise: tuples #1009

Grenkin1988 · 2021-10-22T20:25:01Z

Fixws #863

…8/fsharp into tuples-concept-create

ErikSchierboom · 2021-10-25T07:07:42Z

I'll look at this tomorrow! Thanks.

concepts/tuples/.meta/config.json

concepts/tuples/introduction.md

concepts/tuples/links.json

exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

exercises/concept/tisbury-treasure-hunt/.docs/hints.md

exercises/concept/tisbury-treasure-hunt/.meta/Exemplar.fs

ErikSchierboom · 2021-10-26T11:26:54Z

@Grenkin1988 I've left some comments, but before you look into any of them, I feel like we should first discuss #1009 (comment), as that is key to this exercise.

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Grenkin1988 · 2021-10-26T21:18:19Z

@ErikSchierboom Hopefully I've covered all of the comments.

ErikSchierboom

Looking good! I'll comment on the various markdown documents later. I focused on the other files first.

exercises/concept/tisbury-treasure-hunt/.meta/Exemplar.fs

exercises/concept/tisbury-treasure-hunt/TisburyTreasureHunt.fs

exercises/concept/tisbury-treasure-hunt/.meta/config.json

exercises/concept/tisbury-treasure-hunt/TisburyTreasureHuntTests.fs

ErikSchierboom · 2021-10-27T10:28:09Z

exercises/concept/tisbury-treasure-hunt/.meta/Exemplar.fs

+let getCoordinate (line: string * string): string = snd line
+
+let convertCoordinate(coordinate: string): int * char = 
+    Int32.Parse(string coordinate.[0]), coordinate.[1]


I hadn't considered the fact that we need students to convert a char to an int, which they probably don't know how to do. I do think it's worth keeping an int to really stress the "different types" feature of a tuple. Could you perhaps add a suggestion how to do this to the hints.md file?

Also might be worse adding parsing to the strings concept?
For example we could have some "EventId=1356" in the log message, and as last task to get EventId as an int?

I'm not sure, I'll think on it.

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

exercises/concept/tisbury-treasure-hunt/.docs/introduction.md

concepts/tuples/about.md

exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

concepts/tuples/introduction.md

exercises/concept/tisbury-treasure-hunt/.docs/introduction.md

ErikSchierboom · 2021-10-28T14:38:24Z

exercises/concept/tisbury-treasure-hunt/.docs/introduction.md

+(a + 1, b + 1)
+```
+
+## Obtaining Individual Values


I think it would be nice to move the examples next to the text where the concept is explained. For example, the example of matching a tuple can be moved to the pattern matching example, possibly including the deconstruction code too.

Sorry, not sure I understand what is required

No problem. I can do a follow-up PR later.

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

concepts/tuples/about.md

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

ErikSchierboom · 2021-11-02T10:00:30Z

@Grenkin1988 Happy with the current state of the PR? If so, I can merge this and tweak the introduction phrasing slightly in a follow-up PR (easier that modifying in this PR).

Grenkin1988 · 2021-11-02T10:01:59Z

I guess so

ErikSchierboom

Let's go! Awesome work @Grenkin1988! 🎉

Grenkin1988 · 2021-11-02T10:06:55Z

This was really interesting experience 😸 Hope it wasn't way to terrible 😅

ErikSchierboom · 2021-11-02T10:08:51Z

No not at all! Building Concept Exercises is quite a lot of work, so some churn is to be expected :) You did great!

Grenkin1988 and others added 8 commits October 22, 2021 22:24

Concept is ready, and exercise just copy paste

7d947f3

Merge branch 'exercism:main' into tuples-concept-create

8f66fcf

Add concept slug - tuples

e74d509

Merge branch 'tuples-concept-create' of https://github.com/Grenkin198…

49282cd

…8/fsharp into tuples-concept-create

Update design, introduction and add Exemplar

9e07ed0

Finish the exercise?

3fb4075

Fix typo

4e54dc4

Modify sln

4969e89

Grenkin1988 marked this pull request as ready for review October 23, 2021 11:51

ErikSchierboom reviewed Oct 26, 2021

View reviewed changes

Grenkin1988 and others added 8 commits October 26, 2021 22:12

Merge remote-tracking branch 'origin/main' into tuples-concept-create

5cad567

Fix concept

5b9b6ec

fix instructions

24f89f4

fix config

99a8774

Apply suggestions from code review

e07de40

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Tubles no longer all string

dba112e

Update exercises/concept/tisbury-treasure-hunt/.meta/Exemplar.fs

69ea0c3

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update hints

78daf9c

ErikSchierboom reviewed Oct 27, 2021

View reviewed changes

Grenkin1988 and others added 5 commits October 27, 2021 15:41

Update exercises/concept/tisbury-treasure-hunt/TisburyTreasureHunt.fs

2e3525a

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.meta/Exemplar.fs

b8ec116

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.meta/config.json

792022e

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Fix tests

94135e2

Provide hint for parsing

8cb0763

ErikSchierboom reviewed Oct 28, 2021

View reviewed changes

Grenkin1988 and others added 2 commits October 28, 2021 21:41

Update concepts/tuples/about.md

d5a0332

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/introduction.md

0509d1a

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Grenkin1988 and others added 12 commits October 28, 2021 21:41

Update concepts/tuples/about.md

35f0994

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

d4a93b3

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

aa334d3

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

2f7e5b5

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

a3f5008

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/introduction.md

268988a

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

7e84349

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

3001dcc

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

9938230

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Update exercises/concept/tisbury-treasure-hunt/.docs/instructions.md

745d2ff

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

Merge branch 'exercism:main' into tuples-concept-create

b621a3e

More changes to the texts

819adca

ErikSchierboom reviewed Nov 2, 2021

View reviewed changes

concepts/tuples/about.md Outdated Show resolved Hide resolved

Update concepts/tuples/about.md

40dbdf5

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

ErikSchierboom added the x:size/large Large amount of work label Nov 2, 2021

ErikSchierboom approved these changes Nov 2, 2021

View reviewed changes

ErikSchierboom merged commit 41f85ab into exercism:main Nov 2, 2021

Grenkin1988 deleted the tuples-concept-create branch November 2, 2021 10:06

This was referenced Jul 14, 2022

Document reputation label exercism/docs#347

Merged

Consider correct reputation amounts for different labels exercism/exercism#6440

Open

Consider correct reputation amounts for different labels exercism/exercism#6441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement new Concept Exercise: tuples #1009

Implement new Concept Exercise: tuples #1009

Grenkin1988 commented Oct 22, 2021

ErikSchierboom commented Oct 25, 2021

ErikSchierboom commented Oct 26, 2021

Grenkin1988 commented Oct 26, 2021

ErikSchierboom left a comment

ErikSchierboom Oct 27, 2021

Grenkin1988 Oct 27, 2021

Grenkin1988 Oct 27, 2021

ErikSchierboom Oct 28, 2021

ErikSchierboom Oct 28, 2021

Grenkin1988 Oct 29, 2021

ErikSchierboom Nov 2, 2021

ErikSchierboom commented Nov 2, 2021

Grenkin1988 commented Nov 2, 2021

ErikSchierboom left a comment

Grenkin1988 commented Nov 2, 2021

ErikSchierboom commented Nov 2, 2021

Implement new Concept Exercise: tuples #1009

Implement new Concept Exercise: tuples #1009

Conversation

Grenkin1988 commented Oct 22, 2021

ErikSchierboom commented Oct 25, 2021

ErikSchierboom commented Oct 26, 2021

Grenkin1988 commented Oct 26, 2021

ErikSchierboom left a comment

Choose a reason for hiding this comment

ErikSchierboom Oct 27, 2021

Choose a reason for hiding this comment

Grenkin1988 Oct 27, 2021

Choose a reason for hiding this comment

Grenkin1988 Oct 27, 2021

Choose a reason for hiding this comment

ErikSchierboom Oct 28, 2021

Choose a reason for hiding this comment

ErikSchierboom Oct 28, 2021

Choose a reason for hiding this comment

Grenkin1988 Oct 29, 2021

Choose a reason for hiding this comment

ErikSchierboom Nov 2, 2021

Choose a reason for hiding this comment

ErikSchierboom commented Nov 2, 2021

Grenkin1988 commented Nov 2, 2021

ErikSchierboom left a comment

Choose a reason for hiding this comment

Grenkin1988 commented Nov 2, 2021

ErikSchierboom commented Nov 2, 2021