[New exercise]: pangram #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
force-pushed
the
add-pangram
branch
2 times, most recently
from
88a9076
to
1b839f9
Compare
BNAndras
force-pushed
the
add-pangram
branch
2 times, most recently
from
2036237
to
dbe92ad
Compare
BNAndras
force-pushed
the
add-pangram
branch
from
8d15475
to
f398be9
Compare
|
Okay, I think I got it now, @pfertyk. |
pfertyk
reviewed
Dec 21, 2023
| var lowercase = "abcdefghijklmnopqrstuvwxyz".to_utf8_buffer() | ||
|
|
||
| func is_pangram(sentence): | ||
| var bytes = sentence.to_lower().to_utf8_buffer() |
There was a problem hiding this comment.
Here I believe we just need 1 tab as indent.
pfertyk
reviewed
Dec 21, 2023
| @@ -0,0 +1,57 @@ | |||
| func test_empty_sentence(solution_script): | |||
| var input = "" | |||
There was a problem hiding this comment.
Here I think you are using spaces instead of tabs, could you please switch to tabs instead? (they are the official standard in Godot editor)
pfertyk
reviewed
Dec 21, 2023
pfertyk
reviewed
Dec 21, 2023
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.