Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom-set: ensure generator is up-to-date #629

Closed
robphoenix opened this issue Apr 18, 2017 · 1 comment
Closed

custom-set: ensure generator is up-to-date #629

robphoenix opened this issue Apr 18, 2017 · 1 comment
Labels
good first issue

Comments

@robphoenix
Copy link
Contributor

Parent issue: #604

Because of recent changes to make all the canonical-data.json files conform to
a common scheme (exercism/problem-specifications#625), it might be
the case that our current generator no longer runs.

For this exercise we need to make sure the current generator runs, and if it
doesn't then we need to update it.

In addition, the three lines at the top of the file:

// Source: {{.Ori}}
{{if .Commit}}// Commit: {{.Commit}}
{{end}}

can simply be replaced with {{.Header}}, which has the effect of:

  • Deprecating the Ori field, which is confusingly named
  • Showing the x-common version in the test file
  • Reducing duplicate code
@robphoenix robphoenix mentioned this issue Apr 18, 2017
Merged
leenipper added a commit to leenipper/xgo that referenced this issue Apr 22, 2017
@leenipper
custom-set: update generator
7aa9e52 
For issue exercism#629.

Use .Header in generator template.
Align template with latest canonical-data.json.
Use a OneCase struct type to contain the whole
set of possible json objects for the various
test groups.
Add istrSlice as conversion helper for .Expected.

Rework each define & template call to also generate
the var for the test cases. Use .GroupComment helper function
to output the description for the test case group.
Use dict helper function to pass multiple parameters to a template.

Update test program to change hasCases => containsCases,
and eqCases => equalCases; the new templates
output each test case array var from within the template and simply
prepend the property to "Cases" for the variable name.
leenipper added a commit that referenced this issue Apr 23, 2017
@leenipper
custom-set: update generator (#622)
81b2eaf 
* custom-set: update generator

For issue #629.

Use .Header in generator template.
Align template with latest canonical-data.json.
Use a OneCase struct type to contain the whole
set of possible json objects for the various
test groups.
Add istrSlice as conversion helper for .Expected.

Rework each define & template call to also generate
the var for the test cases. Use .GroupComment helper function
to output the description for the test case group.
Use dict helper function to pass multiple parameters to a template.

Update test program to change hasCases => containsCases,
and eqCases => equalCases; the new templates
output each test case array var from within the template and simply
prepend the property to "Cases" for the variable name.
@robphoenix
Copy link
Contributor Author

Closed by #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robphoenix @leenipper