Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting-room: Implement exercise to teach about type-conversion and type-assertion #1723

Merged
merged 14 commits into from Sep 30, 2021
Merged

Conversation

jmrunkle
Copy link
Contributor

Part of #1645

This is not complete yet since the introduction should be filled out from details in the concepts so leaving it as "wip", but I wanted to start getting feedback.

@jmrunkle jmrunkle marked this pull request as ready for review September 28, 2021 17:38
@jmrunkle jmrunkle requested a review from a team September 28, 2021 17:38
@jmrunkle jmrunkle added the status/awaiting-maintainer This pull request is waiting on one or more maintainers. label Sep 28, 2021
@junedev
Copy link
Member

junedev commented Sep 29, 2021

FYI I merged the concept MRs so their content is now available to be included here.

config.json Show resolved Hide resolved
exercises/concept/sorting-room/.docs/instructions.md Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
@junedev junedev added status/awaiting-contributor This pull request is waiting on the contributor. x:size/large Large amount of work and removed status/awaiting-maintainer This pull request is waiting on one or more maintainers. labels Sep 29, 2021
@bitfield
Copy link
Contributor

I dare say you've already thought about this, but it's worth mentioning that generics will be shipping soon, perhaps as soon as December. We'll need to fit that into our syllabus along with interfaces, won't we? I don't know if you already have an exercise planned for this.

@junedev
Copy link
Member

junedev commented Sep 30, 2021

@bitfield I haven't looked at the final proposal that made it through yet. Do you see an issue with just adding a separate exercise on generics somewhat further down the concept tree?

@jmrunkle
Copy link
Contributor Author

FYI I merged the concept MRs so their content is now available to be included here.

Added material from the concept docs.

@jmrunkle jmrunkle added status/awaiting-maintainer This pull request is waiting on one or more maintainers. and removed status/awaiting-contributor This pull request is waiting on the contributor. labels Sep 30, 2021
@jmrunkle
Copy link
Contributor Author

Ready for another look whenever you are ready @junedev

@bitfield
Copy link
Contributor

My blog post summarises roughly what students will need to know. Yes, we need to tackle interfaces before generics—you could think of generics as further loosening the constraints on what kind of things a function can accept. Instead of just being constrained by method sets, for example io.Reader, they can now be constrained by type lists (all integer types, for example) or by attributes like comparable or constraints.Ordered. So I'm sure we could come up with a similar exercise along those lines.

@junedev
Copy link
Member

junedev commented Sep 30, 2021

Exercise looks good now! Left 2 more tiny comments, feel free to merge whenever you see fit.

jmrunkle and others added 2 commits September 30, 2021 13:22
Co-authored-by: June <12543047+junedev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/awaiting-maintainer This pull request is waiting on one or more maintainers. x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants