-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular expression concept with exercise #2159
Regular expression concept with exercise #2159
Conversation
Dear norbs57Thank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
f1f3282
to
645c2d5
Compare
Fixes exercism#2037 * Concept: regular expressions (in Go) * Concept exercise The first four tasks in the concept exercise are based on tasks in the corresponding C# exercise.
645c2d5
to
6b34ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR! The majority of the changes suggested are aimed at making some explanations a bit more clear.
I suggested the changes to about.md
, but of course they should also be reflected in the other files where the same text is present.
|
||
The [syntax][regexp-syntax] of the regular expressions accepted is the same general syntax used by Perl, Python, and other languages. | ||
|
||
All characters are UTF-8-encoded code points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All characters are UTF-8-encoded code points. | |
In Go, you can use UTF-8 to build your regular expressions. |
I think this sentence is more useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed this to "Both the search patterns and the input texts are interpreted as UTF-8. ". Is that any better?
26d5c25
to
357fd49
Compare
... Co-Authored-By: André Santos <andrerfcsantos@gmail.com>
357fd49
to
914d9bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes to the about.md
- apply to the other relevant files too.
After that, I think this is ready to be merged :)
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Co-authored-by: André Santos <andrerfcsantos@gmail.com>
Fixes #2037
The first four tasks in the concept exercise are based on tasks in the corresponding C# exercise.