pov: Improve code based on HLint's suggestions. #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
reviewed
Sep 25, 2016
| where reparented = reparent (Zipper (crumbToGraph c) cs) | ||
|
|
||
| down :: Zipper a -> Maybe (Zipper a) | ||
| down (Zipper (Graph v (k:kids)) crumbs) = Just (Zipper k ((Crumb v [] kids):crumbs)) | ||
| down (Zipper (Graph v (k:kids)) crumbs) = Just (Zipper k (Crumb v [] kids:crumbs)) |
There was a problem hiding this comment.
Do you think the spacing now makes it look deceptive? It makes it look as if the precedence is Crumb v [] (kids:crumbs), perhaps a space surrounding the : would be fitting? What say you?
There was a problem hiding this comment.
I agree!
Gonna fix as soon as possible.
ps: Sorry for taking so long to answer. I'm temporarily with a very slow Internet connection (It takes at least a minute to load a GitHub page)
petertseng
reviewed
Sep 25, 2016
| down _ = Nothing | ||
|
|
||
| right :: Zipper a -> Maybe (Zipper a) | ||
| right (Zipper here ((Crumb v lefts (r:rights)):cs)) = Just (Zipper r (shifted:cs)) | ||
| right (Zipper here (Crumb v lefts (r:rights):cs)) = Just (Zipper r (shifted:cs)) |
There was a problem hiding this comment.
same question with the space here, I think
There was a problem hiding this comment.
I rewrote both lines, adding spaces and substituting parenthesis by $.
I still don't like how it looks, but I expect it to be a little more readable.
30 tasks
petertseng
approved these changes
Sep 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #355.