bank-account: Supress HLint suggestion #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
petertseng
approved these changes
Sep 27, 2016
|
Another possibility is... to no longer duplicate! For example if we change done of those It is not really important to me which of these two choices we take (ignore duplication hint, or change a value) |
The following suggestion would probably make the tests shorter, but harder to read: ``` ./test/Tests.hs:29:9: Suggestion: Reduce duplication Found: account <- openAccount getBalance account `shouldReturn` Just 0 incrementBalance account 10 `shouldReturn` Just 10 Why not: Combine with ./test/Tests.hs:47:9 1 hint ``` So we just change one of the numbers to silence `hlint` by removing the duplication.
That is a great idea! Let's try it! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #355.
The following suggestion would probably make the tests
shorter, but harder to read:
It is not clear why, but
hlintdoesn't supresses the suggestionsif we use
{-# ANN specs ..., only with{-# ANN module ....