allergies, space-age, meetup-day; Fully define data in stub #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
commented
Jan 8, 2017
| @@ -1,2 +0,0 @@ | |||
| Can't build because the parameters of meetupDay are unused | |||
There was a problem hiding this comment.
also, this particular line (parameters) was back when I was trying to build --pedantic (it did not work out, but I forgot to remove the line)
|
Looks good to me, too. Btw, in the Scala track we also decided to provide stubs at least for the first couple of exercises to not deter beginners, see this issue. |
This is a `data` type whose constructors are already fully defined by the tests, so we provide it to reduce menial work the student has to perform. As part of the work in #466.
This is a `data` type whose constructors are already fully defined by the tests, so we provide it to reduce menial work the student has to perform. As part of the work in #466.
This is a `data` type whose constructors are already fully defined by the tests, so we provide it to reduce menial work the student has to perform. As part of the work in #466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the concrete proposal to go along with #466.
If y'all think #466 is a good idea, then this is the way to go.
Closes #466.