Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Remove error-type examples's cache #551

Merged
merged 2 commits into from
May 25, 2017
Merged

travis: Remove error-type examples's cache #551

merged 2 commits into from
May 25, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented May 25, 2017

Exercise's examples that are always expected to fail the building step are rebuilt by Stack everytime. This triggers a cache update in Travis-CI, even when nothing changed in the repository.

While this problem doesn't affect pull requests that already change the cache, it slows down the all the other PRs by sometimes around 3 minutes.

Removing the cache folder for error-type examples, we expect to have clean rebuilds in Travis.

Closes #544.

Exercise's examples that are always expected to
fail the building step are rebuilt by Stack
everytime. This triggers a cache update in
Travis-CI, even when nothing changed in the
repository.

While this problem doesn't affect pull requests
that already change the cache, it slows down
the all the other PRs by sometimes around 3 minutes.

Removing the cache folder for error-type examples,
we expect to have clean rebuilds in Travis.

Closes #544.
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh OK. I was thinking of just removing all error type tests altogether if they aren't giving us any value but this is fine too.

@rbasso rbasso merged commit f0adbd4 into exercism:master May 25, 2017
@rbasso rbasso deleted the travis-remove-error-type-cache branch May 25, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants