Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for use of Data.Text with twelve-days exercise #876

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Allow for use of Data.Text with twelve-days exercise #876

merged 1 commit into from
Oct 26, 2019

Conversation

chiroptical
Copy link
Contributor

@chiroptical chiroptical commented Oct 25, 2019

This allows students to use Data.Text to solve the twelve-days exercise.

See #841

Copy link
Contributor

@sshine sshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

Since this exercise does not have property tests and is unlikely to have them, the dependency on string-conversions is unnecessary: Since the IsString type class is defined as

class IsString a where
  fromString :: String -> a

we can use fromString to overload the test suite.

This would reduce the PR to .meta/hints.md, the copy of the hint in README.md, and one line in test/Tests.hs.

Comment on lines 33 to 39
You need to implement the `recite` function which outputs the lyrics to
'The Twelve Days of Christmas'. You can use the provided signature
if you are unsure about the types, but don't let it restrict your creativity.

```haskell
recite :: Int -> Int -> [String]
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps remove this:

The Text alternative is provided below, and this type signature already occurs in the stub file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change and also tried to clean up the unordered list phrases. Each entry in the list is an extension of "you can". I hope it reads a bit more cleanly now.

@chiroptical
Copy link
Contributor Author

I squashed my first commit as well.

@sshine sshine merged commit baf9d5a into exercism:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants