Allow for use of Data.Text with twelve-days exercise #876
Conversation
There was a problem hiding this comment.
Thanks for your PR.
Since this exercise does not have property tests and is unlikely to have them, the dependency on string-conversions is unnecessary: Since the IsString type class is defined as
class IsString a where
fromString :: String -> awe can use fromString to overload the test suite.
This would reduce the PR to .meta/hints.md, the copy of the hint in README.md, and one line in test/Tests.hs.
exercises/twelve-days/README.md
Outdated
| You need to implement the `recite` function which outputs the lyrics to | ||
| 'The Twelve Days of Christmas'. You can use the provided signature | ||
| if you are unsure about the types, but don't let it restrict your creativity. | ||
|
|
||
| ```haskell | ||
| recite :: Int -> Int -> [String] | ||
| ``` |
There was a problem hiding this comment.
Perhaps remove this:
The Text alternative is provided below, and this type signature already occurs in the stub file.
There was a problem hiding this comment.
I made this change and also tried to clean up the unordered list phrases. Each entry in the list is an extension of "you can". I hope it reads a bit more cleanly now.
|
I squashed my first commit as well. |
This allows students to use
Data.Textto solve thetwelve-daysexercise.See #841