Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that addons are optional #103

Merged
merged 11 commits into from
Apr 26, 2024
Merged

Make it clear that addons are optional #103

merged 11 commits into from
Apr 26, 2024

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Apr 26, 2024 •
edited
Loading

I assume that the exercises don't depend on any addons? If so, this PR makes it clear that installing them is optional.

eNascimento178
eNascimento178 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@eNascimento178 eNascimento178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the general/unittest is needed. An option would be only point to its intallation like this:

  load 'pacman'
  'update' jpkg ''
  'install' jpkg 'general/unittest'

@ErikSchierboom ErikSchierboom merged commit 7ea464c into main Apr 26, 2024
2 checks passed
@ErikSchierboom ErikSchierboom deleted the addons branch April 26, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eNascimento178 eNascimento178 eNascimento178 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @eNascimento178 @exercism-bot