Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Concept Exercise: Elyses Transformative Enchantments (array-transformations) #1326

Closed
junedev opened this issue Sep 8, 2021 · 6 comments · Fixed by #1388 or #1587
Closed
Assignees
Labels
x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:size/large Large amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)

Comments

@junedev
Copy link
Member

junedev commented Sep 8, 2021

The goal of this task is to make sure the Concept Exercise "Elyses Transformative Enchantments" conform to the latest specification. As part of that, the concept array-transformations has to be created.

The docs can be found here

Additionally you can look at the bird-watcher concept exercise for reference.

The improvement should include changing the introduction.md file of the exercise to contain some minimal information so that the student is able to solve the exercise. For now it is ok to use that same content as introduction.md and about.md for the Concept as well.

Also ensure that

Here is a general idea for the introduction that was discussed before:
Show how to do something like map or filter with a simple for loop, then show how to do it with the helper method instead. Afterwards provide a table with the common helpers. Just the method name as a link (e.g. to MDN) and a short explanation what this is for. We think its ok if the student reads up on some details of these methods on their own, we don't want to show and explain every single one in detail. Also the list can contain more things, than needed for the exercise (we count that info as "necessary to understand the concept" in contrast to "necessary to solve the exercise").

It might make sense to replace the fill task of the exercise (the last one) with reverse instead as that is probably more commonly used.

@junedev junedev added x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/large Large amount of work labels Sep 8, 2021
@TomPradat
Copy link
Contributor

There is no array-transformations concept yet on this track. Does this issue mean that one should be created?

@junedev
Copy link
Member Author

junedev commented Sep 22, 2021

Good point. I didn't notice the folder does not even exist yet. Yes, the concept needs to be created and added to the config.json file.
(I updated the description.)

@TomPradat
Copy link
Contributor

Can I work on this?

@junedev
Copy link
Member Author

junedev commented Sep 22, 2021

Yes, that would be great! Note that I extended the issue description with some ideas about the introduction that I discussed with DJ but forgot to write down before.

@junedev
Copy link
Member Author

junedev commented Dec 26, 2021

The array transformation concept exists now. The following tasks are left:

  • Double check/improve the exercise as described above.
  • Change the task that currently uses fill to instead teach reverse. Make sure to also adjust the hints, instructions etc.
  • Add sort to the concept.
  • Copy the concept introduction into the exercise introduction.

@junedev
Copy link
Member Author

junedev commented Dec 28, 2021

I will work on the remaining tasks so we can get the exercise live soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:size/large Large amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
2 participants