Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Fix exercise names, fix documents, fix all the things #1017

Closed
8 of 10 tasks
SleeplessByte opened this issue Feb 28, 2021 · 3 comments
Closed
8 of 10 tasks

[V3] Fix exercise names, fix documents, fix all the things #1017

SleeplessByte opened this issue Feb 28, 2021 · 3 comments
Assignees
@SleeplessByte
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. documentation 📖 Documentation changes enhancement 🦄 Changing current behaviour, enhancing what's already there

Comments

@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 28, 2021 •
edited by junedev
Loading

I know what needs to be done, so... there's that. This issue is just so I can write things down between times I can work on this, and so other people could pick it up should something happen to me (nothing planned!, just in case).

I will also reference this issue from PRs related.

IF YOU ARE WORKING ON THIS

Please let me know in this issue so I don't work on it. Anything listed above is being worked on by someone. I tick them off once there is a PR.
@SleeplessByte SleeplessByte added enhancement 🦄 Changing current behaviour, enhancing what's already there documentation 📖 Documentation changes chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. labels Feb 28, 2021
@SleeplessByte SleeplessByte self-assigned this Feb 28, 2021
This was referenced Feb 28, 2021
Merged
Merged
Merged
@SleeplessByte SleeplessByte mentioned this issue Mar 16, 2021
Merged
@SleeplessByte SleeplessByte mentioned this issue Apr 2, 2021
Merged
This was referenced Apr 16, 2021
Merged
Merged
@angelikatyborska
Copy link
Member

angelikatyborska commented Aug 21, 2021 •
edited
Loading

I'm going to work this weekend on "fixing everything" about Elyses Destructured Enchantments

Edit: PR #1274

@junedev
Copy link
Member

junedev commented Aug 23, 2021 •
edited
Loading

Just for reference, errors also needs to be fixed as @angelikatyborska noted here. In particular it is missing the exercise entry in the global config.json file.

@junedev junedev mentioned this issue Aug 25, 2021
Merged
@junedev
Copy link
Member

junedev commented Sep 8, 2021

I created more descriptive issues for the remaining items on the list above, closing this one.
#1325
#1326

That way it is easier for people to see that there are already open issues for these exercises and to add comments there instead of opening a new issue.

@junedev junedev closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SleeplessByte SleeplessByte

Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. documentation 📖 Documentation changes enhancement 🦄 Changing current behaviour, enhancing what's already there
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SleeplessByte @angelikatyborska @junedev