-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V3] Lucian's Lucious Lasagna: fix everything around this exercise #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look awesome. Really like the intro blurbs and the > 💡 quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing https://github.com/exercism/javascript/pull/1021/files#, I checked the hints.md
file of this exercise. It looks like the link to the arithmetic operators no longer refers to the right section, which is probably due to a change in the URL structure as MDN.
Old url: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators
New url: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators#arithmetic_operators
It might be worth updating the URL for the hints.
@ErikSchierboom I think MDN didn't get the notion that https://www.w3.org/Provider/Style/URI.html |
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
763c625
to
8fd1ed1
Compare
Reviewers, please spell/grammar check
Related #1017
Changes
basics
) to story based exerciselasagna
config.json
basics
toconfig.json