Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Poetry Club Door Policy: fix everything around this exercise #1043

Merged
merged 16 commits into from
Apr 2, 2021

Conversation

SleeplessByte
Copy link
Member

Reviewers, please spell/grammar check

Related #1017

Changes

  • Rename from concept based exercise (strings) to story based exercise policy-club-door-policy
  • Add full name to config.json
  • Add blurb for strings to config.json
  • Add a small welcome block to the stub
  • Add design document
  • Sync concept documents with exercise documents
  • Add concept links
  • Add about.md for strings concept

@SleeplessByte SleeplessByte requested a review from a team March 16, 2021 00:42
@SleeplessByte SleeplessByte added chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. documentation 📖 Documentation changes enhancement 🦄 Changing current behaviour, enhancing what's already there v3-migration 🤖 Preparing for Exercism v3 labels Mar 16, 2021
concepts/strings/about.md Show resolved Hide resolved
concepts/strings/about.md Outdated Show resolved Hide resolved
concepts/strings/about.md Outdated Show resolved Hide resolved
exercises/concept/poetry-club-door-policy/.docs/hints.md Outdated Show resolved Hide resolved
- There are two methods to take a part of a string (for example, everything
except the first character).
- Capitalization means having a single Uppercase character, followed by lowercase characters.
- There are two methods to take a part of a string (for example, everything except the first character).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has me on the edge of my seat, feeling like the two method names might be coming up… but then, like the ending of Monty Python and the Holy Grail, kind of leaves you wondering what happened.

Perhaps "to take a part of a string" can be stated "to take a portion of a string" as "apart" and "a part" has simlar meanings, and I believe a portion rather than dissassemble is meant here. No need to change (of course) if that is only my take on that wording though.

exercises/concept/poetry-club-door-policy/.docs/hints.md Outdated Show resolved Hide resolved
@SleeplessByte SleeplessByte force-pushed the chore/rename-strings branch from e255f51 to 6530848 Compare April 2, 2021 18:22
@SleeplessByte
Copy link
Member Author

/sync

@exercism exercism deleted a comment from github-actions bot Apr 2, 2021
@exercism exercism deleted a comment from github-actions bot Apr 2, 2021
@SleeplessByte
Copy link
Member Author

/format

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

The "Format code" action has started running.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

The "Format code" action has finished running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. documentation 📖 Documentation changes enhancement 🦄 Changing current behaviour, enhancing what's already there v3-migration 🤖 Preparing for Exercism v3 x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants