Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy between docs and test case #1394

Closed
joshuaswickirl opened this issue Oct 1, 2021 · 0 comments · Fixed by #1413
Closed

Discrepancy between docs and test case #1394

joshuaswickirl opened this issue Oct 1, 2021 · 0 comments · Fixed by #1413
Labels
bug 🐛 Something isn't working x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:size/small Small amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)

Comments

@joshuaswickirl
Copy link

The comment on purchaseInventoryIfAvailable in fruit-picker.js says arg should be bool but a test case expects passing an object to return "PURCHASE" as if this is an expected type.

javascript/exercises/concept/fruit-picker/fruit-picker.js

Line 38 in 669ddc8

* @param {boolean} isAvailable

javascript/exercises/concept/fruit-picker/fruit-picker.spec.js

Line 74 in 669ddc8

expect(purchaseInventoryIfAvailable(null, { quantityAvailable: 4 })).toBe(

The test case should be replaced by a bool or the comment should be updated to show different types are expected.
@SleeplessByte SleeplessByte added bug 🐛 Something isn't working x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts) labels Oct 2, 2021
qianzhong516 added a commit to qianzhong516/javascript that referenced this issue Oct 7, 2021
@qianzhong516
Fixed fruit-picker test case (exercism#1394)
84bc8c6
@junedev junedev mentioned this issue Oct 7, 2021
Merged
@junedev junedev added the x:status/claimed Someone is working on this issue label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:size/small Small amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed fruit-picker test case (#1394) qianzhong516/javascript
3 participants
@SleeplessByte @junedev @joshuaswickirl