Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Concept Exercise: For Loops #1059

Merged
merged 22 commits into from
Mar 29, 2021

Conversation

junedev
Copy link
Member

@junedev junedev commented Mar 28, 2021

Addresses #990

Notes

  • Since we do not have a concept about asynchronous code yet and it is hard to predict how we will cover this topic exactly, I am currently linking to the MDN docs instead although there are not a super good introduction.
  • I used some prettier exceptions in the about.md for for loops because otherwise the main point of the examples was very hard to see, hope that is ok.

Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @junedev, a nice straight-forward exercise! I left one question about variable scope, I wasn't sure if that had been implemented yet or if it was on the priority list.

LGTM

concepts/for-loops/about.md Outdated Show resolved Hide resolved
@neenjaw
Copy link
Contributor

neenjaw commented Mar 28, 2021

@SleeplessByte can you apply thereputation/contributed_code/major label to this? I think the labels are locked on this repo

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

concepts/for-loops/about.md Outdated Show resolved Hide resolved
concepts/for-loops/about.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

The "Sync all exercises" action has started running.

@junedev
Copy link
Member Author

junedev commented Mar 29, 2021

/sync

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@junedev
Copy link
Member Author

junedev commented Mar 29, 2021

I can't get the sync check to pass. I tried npx babel-node scripts/sync locally, no change. I tried /sync here, did not do anything. I tried an empty commit to rerun the check, still not working. What's wrong?
cc @SleeplessByte

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@SleeplessByte SleeplessByte force-pushed the add-concept-exercise-for-loops branch from 9266ffb to cc3d273 Compare March 29, 2021 19:19
@junedev

This comment has been minimized.

@SleeplessByte
Copy link
Member

/sync

@github-actions
Copy link
Contributor

The "Sync all exercises" action has started running.

@github-actions
Copy link
Contributor

The "Sync all exercises" action has finished running.

@github-actions
Copy link
Contributor

For security reasons, /sync does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Member

I can't get the sync check to pass. I tried npx babel-node scripts/sync locally, no change. I tried /sync here, did not do anything. I tried an empty commit to rerun the check, still not working. What's wrong?
cc @SleeplessByte

The pull_request pr check (I think) runs on a merged detached head (which is great). So what has happened here is that the base branch main was actually updated and after merge, this exercise would not be in sync.

  1. git checkout main
  2. git fetch upstream
  3. git rebase upstream/main
  4. git checkout <your branch>
  5. git rebase main
  6. git push --force

Now syncing does work.

(I've done this for you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants