Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resistor-colors exercise #642

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Implement resistor-colors exercise #642

merged 1 commit into from
Mar 26, 2019

Conversation

tejasbubane
Copy link
Member

@tejasbubane tejasbubane commented Mar 22, 2019 •
edited
Loading

Problem spec PR: exercism/problem-specifications#1466

Closes #641

@SleeplessByte
Copy link
Member

Looks fine on first skim.

Don't merge ⚠️ yet -- Maud and I are figuring out if we want to combine #639 #640 #641 in one go.

SleeplessByte
SleeplessByte reviewed Mar 25, 2019
View reviewed changes
config.json Outdated Show resolved Hide resolved
SleeplessByte
SleeplessByte requested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

@SleeplessByte
Copy link
Member

Discussed this with Maud. We'll be merging #640 + #639 + #641 simultaneously as a track anatomy experiment.

@SleeplessByte SleeplessByte mentioned this pull request Mar 26, 2019
Closed
18 tasks
@SleeplessByte
Copy link
Member

Don't forget to update and copy

  • package.json
  • babel.config.js
  • .eslintrc

@emcoding
Copy link

Fantastic!

@tejasbubane
Copy link
Member Author

@SleeplessByte Done

@SleeplessByte SleeplessByte merged commit c1d9030 into exercism:master Mar 26, 2019
@emcoding
Copy link

Yay!

@tejasbubane tejasbubane deleted the resistor-colors branch March 27, 2019 13:41
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte requested changes

Assignees
No one assigned
Labels
new exercise ✨ x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tejasbubane @SleeplessByte @emcoding @ErikSchierboom