New Exercise: Promises #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slaymance before reviewing, can you make the CI's pass? |
|
Thanks <3 |
SleeplessByte
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Alright. This is looking like a great addition to the practice exercises. I have no things you should change. I like it.
In order to merge (sorry!) two more things:
- move the
promisesfolder intopractice - then rebase (watch out:
package.jsonhas a keypracticetoo, now) - run
npm iin the root - run
ASSIGNMENT=practice/promises npx babel-node scripts/syncin the root
As far as I'm concerned, it's mergable right after.
SleeplessByte
force-pushed
the
exercise/promises
branch
from
b2e9ec7 to
c586407
Compare
|
@slaymance I performed the tasks, added introduction, added .meta/config files and added you as the Author. Thanks for contributing :) |
ErikSchierboom
added
x:size/large
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to add an exercise which focuses on
Promises since they're such a core part of JS development. My idea was to ask learners to implement a function that behaves like NodeJS'sutil.promisify, as well as thePromisestatic helper methods in native JS:Promise.allPromise.allSettledPromise.racePromise.anyI've included some tests for each function as a starting point and an example implementation of all the functions. I'd love some feedback and additional contributions. I think this would make a great language-specific exercise!