Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex concept #125

Merged
merged 10 commits into from
Jan 8, 2023
Merged

Regex concept #125

merged 10 commits into from
Jan 8, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Jan 5, 2023 •
edited
Loading

Summary

Create the Regular Expressions concept.
Create the "Regular Chatbot" exercise.

Closes #122

Checklist

  • If docs where changed, run ./bin/configlet generate to ensure all documents are properly generated.
  • CI is green

@glennj glennj added the x:rep/large Large amount of reputation label Jan 5, 2023
@glennj glennj requested a review from IsaacG January 5, 2023 23:29
@glennj glennj mentioned this pull request Jan 6, 2023
Open
12 tasks
IsaacG
IsaacG reviewed Jan 6, 2023
View reviewed changes
concepts/regular-expressions/about.md Outdated Show resolved Hide resolved
concepts/regular-expressions/about.md Outdated Show resolved Hide resolved
concepts/regular-expressions/about.md Outdated Show resolved Hide resolved
concepts/regular-expressions/about.md Outdated Show resolved Hide resolved
concepts/regular-expressions/about.md Outdated Show resolved Hide resolved
exercises/concept/regular-chatbot/regular-chatbot.jq Outdated Show resolved Hide resolved
exercises/concept/regular-chatbot/regular-chatbot.jq Outdated Show resolved Hide resolved
exercises/concept/regular-chatbot/regular-chatbot.jq Outdated Show resolved Hide resolved
exercises/concept/regular-chatbot/regular-chatbot.jq Outdated Show resolved Hide resolved
exercises/concept/remote-control-car/.docs/introduction.md Show resolved Hide resolved
glennj and others added 2 commits January 6, 2023 11:08
@glennj @IsaacG
Apply suggestions from code review
9b12abf 
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@glennj
review suggestions
bbf0c28
@glennj glennj requested a review from IsaacG January 6, 2023 16:38
@glennj
Copy link
Contributor Author

glennj commented Jan 6, 2023

The main question: does the concept and exercise satisfy the design goals?

@IsaacG
Copy link
Member

IsaacG commented Jan 7, 2023

The main question: does the concept and exercise satisfy the design goals?

I believe it does!

@glennj glennj merged commit d735741 into exercism:main Jan 8, 2023
@glennj glennj deleted the regex-concept branch January 8, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG approved these changes

Assignees
No one assigned
Labels
x:rep/large Large amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regular Expressions concept
2 participants
@glennj @IsaacG