Collapse testsets #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple passing results are collapsed into a single report. At most 5 failing results are reported per testset.
This reverts commit 2c7d29f. These error messages are right on my machine, but maybe not on the CI
Merged
cmcaine
force-pushed
the
collapse-testsets
branch
from
a8ca0e5 to
201bc23
Compare
SaschaMann
approved these changes
May 23, 2022
| @@ -61,11 +61,23 @@ jobs: | |||
|
|
|||
| const tests = split(ENV["TESTS"], ",") | |||
|
|
|||
| # Shorten the error messages so we don't need to care about specific paths, file numbers, etc. | |||
There was a problem hiding this comment.
Just to clarify, this only affects CI, not the end result on the website?
There was a problem hiding this comment.
Well, it affects a local run of the tests with pkg, too. But in any case, doesn't affect the website. Just got tired of the fixtures changing because of path differences and so on.
|
Thanks for the review! I couldn't think of a nice way to show a warning and I wasn't convinced it would be very helpful, so I think we should merge this without adding one. Can always do another PR if it seems like a good idea. I'll rebase and merge this later today or tomorrow if you've no objections :) |
This was referenced May 23, 2022
Merged
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Please don't squash these commits: there are quite a few changes and the atomic commits make it easier to understand what's going on + the changes to the fixtures between 154e5a9 and c3b5396 make it easy to see what the effect of this PR is without having to run the tests yourself.
Changes:
a7b986f (Colin Caine, 53 seconds ago)
Report test_code for passing tests
c3b5396 (Colin Caine, 10 minutes ago)
Report fewer results
Multiple passing results are collapsed into a single report. At most 5
failing results are reported per testset.
154e5a9 (Colin Caine, 5 minutes ago)
Add fixtures to test collapsing behaviour
2c7d29f (Colin Caine, 6 minutes ago)
Update error messages in fixtures