Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exercise structure to README #6

Merged
merged 2 commits into from
Nov 29, 2016
Merged

Added exercise structure to README #6

merged 2 commits into from
Nov 29, 2016

Conversation

SaschaMann
Copy link
Contributor

@SaschaMann SaschaMann commented Nov 27, 2016

As discussed in issue #2.

Closes #2

As discussed in issue #2.
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I have a couple of minor comments.

`exercises/<name>/runtests.jl` Test suite for the exercise. Group related tests using [testsets](http://docs.julialang.org/en/release-0.5/stdlib/test/#working-with-test-sets).

`exercises/<name>/example.jl` Example solution for the exercise. It should follow the [Julia Style Guide](http://docs.julialang.org/en/release-0.5/manual/style-guide/).
<!-- See Issue 2 for discussion -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this an actual link to the issue: #2

`exercises/<name>/example.jl` Example solution for the exercise. It should follow the [Julia Style Guide](http://docs.julialang.org/en/release-0.5/manual/style-guide/).
<!-- See Issue 2 for discussion -->

(`<name>` refers to the exercise name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using the word slug for this elsewhere. It's the URL-friendly identifier for a given exercise. The name of the exercise is what would go in the title of the README for it. So:

  • name: Hello World
  • slug: hello-world

We've actually struggled quite a lot with terminology, and thrashed around a lot so you'll probably see remnants of old names strewn around various codebases and issues and pull requests.

@SaschaMann
Copy link
Contributor Author

Applied your suggestions. Not quite sure if that's what you meant with the slug-comment. Let me know if it's not.

@kytrinyx
Copy link
Member

Yepp, this looks great! Thanks.

@kytrinyx kytrinyx merged commit 894ecb7 into exercism:master Nov 29, 2016
@SaschaMann SaschaMann deleted the patch-1 branch November 29, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants