Update Kotlin and Gradle #505
Conversation
…est Gradle version.
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation(kotlin("stdlib")) | ||
| implementation(kotlin("stdlib-jdk8")) |
There was a problem hiding this comment.
Don't we want jdk11, or even jdk17?
There was a problem hiding this comment.
stdlib-jdk8 adds some extensions for Java 8 specific classes or features, like the new date/time API and some new collection methods, as well as features added in Java 7 (in the transitive stdlib-jdk7 artifact). There's no features (yet) that target Java 11+ or Java 17+ features so there are no additional stdlib artifacts for those (yet).
Should probably remove these tho. |
|
Changed this to a draft for now. As discussed in Slack, planning on making another update once Gradle 7.3 and Kotlin 1.6 are released. |
|
Sounds good! |
This is an invalid character for Windows filenames and causes Windows systems to fail the tests.
…additional warnings by hand.
|
Made the following changes:
Thinking we're good to merge now. |
|
The I am a bit wary that we don't have any CI that will determine if this change will break the track, but I think issues would be opened switfly if it does ;) |
|
@incendium Great! Could you maybe also add a test case to the Kotlin test runner tests: https://github.com/exercism/kotlin-test-runner/tree/main/tests? That test case should use the new exercise structure (with the latest Gradle version). |
|
Sure, I will take a look at doing that when I get some free time. |
This PR is intended to tackle #494 and #495 as a first step towards helping reduce the build time issues wrt. exercism/kotlin-test-runner#30.
A summary of the changes:
./gradlew buildinexerciseswill work now). All tests passed before I opened this PR.settings.gradle.ktsfile to each template to control the Kotlin version instead of directly defining it in thebuild.gradle.ktsfile. This structure will play nicer with the Gradle KTS dialect in the multi-module project setup, and I have also manually verified that it works in standalone mode. It's not quite ideal but it works.|to use-instead as using|causes Windows systems to fail to compile the tests.A future task is probably to update the JUnit tests to use v5 instead of v4, as I noticed some of the newer exercises are using JUnit 5. This should be relatively easy to do with the vintage test runner for JUnit 5.