-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hello-world: update to new x-common canonical-data #193
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
local hello_world = {} | ||
|
||
function hello_world.hello( name ) | ||
if not name or name == '' then name = 'world' end | ||
return 'Hello, ' .. name .. '!' | ||
function hello_world.hello() | ||
return 'Hello, World!' | ||
end | ||
|
||
return hello_world |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
-- This is a "stub" file. It's a little start on your solution. | ||
-- It's not a complete solution though; you have to write some code. | ||
|
||
-- Table to be returned by the hello-world module. | ||
local hello_world = {} | ||
|
||
-- Add the hello() function to the table returned by this module. | ||
function hello_world.hello() | ||
-- Write some code here to pass the test suite. | ||
|
||
-- When you have a working solution, REMOVE ALL THE STOCK COMMENTS. | ||
-- They're here to help you get started but they only clutter a finished solution. | ||
-- If you leave them in, reviewers will protest! | ||
return '' | ||
end | ||
|
||
-- Return the hello_world table to make it accessible as a module. | ||
return hello_world |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,12 @@ | ||
-- Require the hello-world module | ||
local hello_world = require('hello-world') | ||
|
||
-- Define a module named hello-world. This module should return a single | ||
-- function named hello that takes no arguments and returns a string. | ||
|
||
describe('hello-world', function() | ||
it('says hello world with no name', function() | ||
it('says hello world', function() | ||
local result = hello_world.hello() | ||
assert.are.equal('Hello, world!', result) | ||
end) | ||
|
||
it('says hello to Bob', function() | ||
local result = hello_world.hello('Bob') | ||
assert.are.equal('Hello, Bob!', result) | ||
end) | ||
|
||
it('says hello to Sally', function() | ||
local result = hello_world.hello('Sally') | ||
assert.are.equal('Hello, Sally!', result) | ||
assert.are.equal('Hello, World!', result) | ||
end) | ||
end) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍