Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello-world: update to new x-common canonical-data #193

Merged
merged 2 commits into from
Feb 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions exercises/hello-world/example.lua
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
local hello_world = {}

function hello_world.hello( name )
if not name or name == '' then name = 'world' end
return 'Hello, ' .. name .. '!'
function hello_world.hello()
return 'Hello, World!'
end

return hello_world
18 changes: 18 additions & 0 deletions exercises/hello-world/hello-world.lua
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
-- This is a "stub" file. It's a little start on your solution.
-- It's not a complete solution though; you have to write some code.

-- Table to be returned by the hello-world module.
local hello_world = {}

-- Add the hello() function to the table returned by this module.
function hello_world.hello()
-- Write some code here to pass the test suite.

-- When you have a working solution, REMOVE ALL THE STOCK COMMENTS.
-- They're here to help you get started but they only clutter a finished solution.
-- If you leave them in, reviewers will protest!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return ''
end

-- Return the hello_world table to make it accessible as a module.
return hello_world
18 changes: 6 additions & 12 deletions exercises/hello-world/hello-world_spec.lua
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
-- Require the hello-world module
local hello_world = require('hello-world')

-- Define a module named hello-world. This module should return a single
-- function named hello that takes no arguments and returns a string.

describe('hello-world', function()
it('says hello world with no name', function()
it('says hello world', function()
local result = hello_world.hello()
assert.are.equal('Hello, world!', result)
end)

it('says hello to Bob', function()
local result = hello_world.hello('Bob')
assert.are.equal('Hello, Bob!', result)
end)

it('says hello to Sally', function()
local result = hello_world.hello('Sally')
assert.are.equal('Hello, Sally!', result)
assert.are.equal('Hello, World!', result)
end)
end)