Skip to content

Commit

Permalink
Dockerfile: install tcc-libs-static (#170)
Browse files Browse the repository at this point in the history
Despite no change to the Dockerfile on our end, we were seeing an error:

    tcc: error: libtcc1.a not found

This was due to Alpine splitting the tcc package [1] into:

- tcc

- tcc-dev

- tcc-doc

- tcc-libs

- tcc-libs-static

combined with the other underlying problems:

- The tcc package isn't pinned, because we can't reliably pin package
  versions on Alpine [2]

- The tcc package in Alpine is in the testing repo, which makes breaking
  changes more likely

- The CI workflow was skipped in a PR that changed only docs, but would
  have failed if it ran

- The deployment workflow runs on main even if the CI workflow fails on
  main

Install the new tcc-libs-static subpackage so that libtcc1.a is
available again. See the contents of the tcc packages [3][4][5][6][7].

This commit also bumps the tcc version, because the current state [8]
was deployed after the upstream bump [9].

Fixes: #165
Fixes: #166

[1] https://git.alpinelinux.org/aports/commit/?id=e2fff91d821a89e4ce5a205207181ed9fdb18c16
[2] https://gitlab.alpinelinux.org/alpine/abuild/-/issues/9996
[3] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc&arch=x86_64&repo=testing
[4] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2ddev&arch=x86_64&repo=testing
[5] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2ddoc&arch=x86_64&repo=testing
[6] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2dlibs&arch=x86_64&repo=testing
[7] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2dlibs%2dstatic&arch=x86_64&repo=testing
[8] bcb2010, 2023-10-06, ".github(pause-community-contributions): add custom token"
[9] https://git.alpinelinux.org/aports/commit/testing?id=d697e994f093e65208d05a83bf2a0a9750002d20
  • Loading branch information
ee7 authored Mar 8, 2024
1 parent 05911af commit eb12635
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ RUN apk add --no-cache \
pcre \
&& apk add --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/edge/testing \
tcc \
tcc-libs-static \
&& ln -s /nim/bin/nim /usr/local/bin/nim
WORKDIR /opt/test-runner/
COPY --from=runner_builder /build/runner bin/
Expand Down

0 comments on commit eb12635

Please sign in to comment.