Build: use Exercism's base docker image of nim for test-runner #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `exercism/nim-docker-base:18a2d8619faf474ee7afc7ae499f111271eb4e12` to copy over the alpine version of nim for the test-runner because it is already built and doesn't have to be rebuilt on every CI test.
|
@iHiD @ErikSchierboom is on vacation now (if I understand correctly) so am tagging you as code owner instead |
ynfle
deleted the
ci-reduce-docker-build-time-with-exercism-base-nim-image
branch
|
@ErikSchierboom I thought you were on vacation! Thanks for the approval |
|
@ynfle I'm doing reviews once a week :) But yes: I am officially on vacation. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
exercism/nim-docker-base:18a2d8619faf474ee7afc7ae499f111271eb4e12to copy over the alpine version of nim for the test-runner because it is already built and doesn't have to be rebuilt on every CI test.The build times are reduced from ~7.5-8.5 minutes to ~2.5-3.5 minutes (still twice as slow as on ubuntu itself)
The reason for the time reduction is that it takes ~5.5-6.5 minutes to compile the nim compiler which is not related to the test runner itself and can be (and is offloaded) to https://github.com/exercims/nim-docker-base. Which only has to compile the nim compiler once for every change to the Dockerfile as it changes rarely and when it does it's mostly due to dependency upgrades.