-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: several typos in concepts #548
Conversation
you need to fix also the underlying concepts which are used in the template generation. you can find them in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Thanks for the comment. There is still the mysterious failure of one check, even though the other PR worked 🤷 |
That CI failing is because that step generates a difference between the hydrated template and the resulting introduction document. So when it tries to commit the difference in the branch, it fails since it doesn't have permission to commit to your branch (nothing for you to fix there). If you pull this locally then run from the repository root directory: ./bin/fetch_configlet then ./bin/configlet generate you will be able to see the difference generated. So next time it might be easier to have this workflow:
(Side note, @ee7 can we add a comment to files computed by configlet generate that they are auto-generated and not to be manually edited? It might ease this process next time someone is onboarding) |
Yeah, we could do that. It's tracked in exercism/configlet#655. But it'll also help when |
@neejaw Thank you for posting those steps. I thought the problem was the same as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Yes, maybe we could add those suggestion to that workflow when it fails to be a bit more helpful when this situation happens. Do you want to look into that process with GitHub actions?
I have zero experience with GitHub Actions, so it would be probably more of exploring and getting familiar with than help. |
It's just a nice to have, no real rush on it. :D |
No description provided.