Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stubs for all exercises, brought up to modern pony. #125

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Added stubs for all exercises, brought up to modern pony. #125

merged 3 commits into from
Aug 23, 2022

Conversation

redvers
Copy link

@redvers redvers commented Aug 20, 2022

First in the TODO list to get this track back on track.

All exercises now have stubs with the correct function signatures so that the examples will compile but (obviously and correctly) fail tests.

@iHiD iHiD requested a review from a team August 21, 2022 22:39
@redvers redvers mentioned this pull request Aug 22, 2022
Closed
kotp
kotp reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the PR, I think it could come in, but if the changes are good as suggested, these could also come in. (in other words, not a show stopper.)

exercises/practice/roman-numerals/roman_numerals.pony Outdated Show resolved Hide resolved
exercises/shared/.docs/debug.md Outdated Show resolved Hide resolved
exercises/practice/anagram/anagram.pony Outdated Show resolved Hide resolved
ErikSchierboom
ErikSchierboom approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work! Some tiny nits.

I've approved so that you can merge when you've had a look at the nits.

exercises/shared/.docs/debug.md Outdated Show resolved Hide resolved
exercises/shared/.docs/tests.md Outdated Show resolved Hide resolved
@redvers redvers merged commit 4c0896c into exercism:main Aug 23, 2022
This was referenced Aug 23, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp left review comments

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redvers @kotp @ErikSchierboom