-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alphametics: Update test description #1045
Conversation
The test contains 199 addends, not 41. Sorry
Yup. Please prefix commit message and PR description with "alphametics:" I would like to take this without changing version since this is something that should have happened with 1.1.0 However I guess there is a possibility that someone could have used 1.1.0 to generate. I could check all the repos to see whether anyone in fact did so, but lazy. So, I think we have to have version 1.1.1, unless there is more agreement that staying 1.1.0 is OK. I don't care either way but if I don't hear from anyone else I'm going to ask 1.1.1. |
I think to be PC the version should be bumped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One small nit: could you update the patch version?
Like this? |
@nikamirrr Yes, precisely! |
Added a patch version
Thanks @nikamirrr! |
Absolutely! Thank you, I am not a pro developer, and this is the opportunity for me to get more familiar with github and such. |
1.1.0: new test exercism/problem-specifications#1024 1.1.1: description exercism/problem-specifications#1045 1.2.0: input object exercism/problem-specifications#1035
The test contains 199 addends, not 41. Sorry