Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alphametics: Update test description #1045

Merged
merged 2 commits into from
Jan 4, 2018
Merged

Conversation

nikamirrr
Copy link
Contributor

The test contains 199 addends, not 41. Sorry

The test contains 199 addends, not 41. Sorry
@petertseng
Copy link
Member

Yup.

Please prefix commit message and PR description with "alphametics:"

I would like to take this without changing version since this is something that should have happened with 1.1.0

However I guess there is a possibility that someone could have used 1.1.0 to generate. I could check all the repos to see whether anyone in fact did so, but lazy.

So, I think we have to have version 1.1.1, unless there is more agreement that staying 1.1.0 is OK. I don't care either way but if I don't hear from anyone else I'm going to ask 1.1.1.

@rpottsoh rpottsoh changed the title Updated one test description alphametics: Update test description Dec 22, 2017
@rpottsoh
Copy link
Member

I think to be PC the version should be bumped.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One small nit: could you update the patch version?

@nikamirrr
Copy link
Contributor Author

Like this?
"version": "1.1.0" -> "version": "1.1.1",

@ErikSchierboom
Copy link
Member

@nikamirrr Yes, precisely!

@rpottsoh rpottsoh merged commit f7936d0 into exercism:master Jan 4, 2018
@ErikSchierboom
Copy link
Member

Thanks @nikamirrr!

@nikamirrr
Copy link
Contributor Author

Absolutely! Thank you, I am not a pro developer, and this is the opportunity for me to get more familiar with github and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants