wordy: implement "error" object #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Insti
reviewed
Sep 21, 2018
exercises/wordy/canonical-data.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "exercise": "wordy", | |||
| "version": "1.1.0", | |||
| "version": "1.2.0", | |||
| "comments": [ | |||
| "The tests that expect 'false' should be implemented to raise", | |||
| "an error, or indicate a failure. Implement this in a way that", | |||
There was a problem hiding this comment.
This comment should probably be modified.
ErikSchierboom
requested changes
Sep 23, 2018
exercises/wordy/canonical-data.json
Outdated
| @@ -125,15 +125,15 @@ | |||
| "input": { | |||
| "question": "What is 52 cubed?" | |||
| }, | |||
| "expected": false | |||
| "expected": {"error": "Invalid Problem"} | |||
There was a problem hiding this comment.
Maybe change this to Invalid problem (lowercase p)?
exercises/wordy/canonical-data.json
Outdated
| }, | ||
| { | ||
| "description": "Non math question", | ||
| "property": "answer", | ||
| "input": { | ||
| "question": "Who is the President of the United States?" | ||
| }, | ||
| "expected": false | ||
| "expected": {"error": "Invalid Problem"} |
There was a problem hiding this comment.
Maybe change this to Invalid problem (lowercase p)?
Insti
reviewed
Sep 24, 2018
exercises/wordy/canonical-data.json
Outdated
| @@ -125,15 +125,15 @@ | |||
| "input": { | |||
| "question": "What is 52 cubed?" | |||
| }, | |||
| "expected": false | |||
| "expected": {"error": "Invalid problem"} | |||
There was a problem hiding this comment.
This is OK, but the error message could probably be worded more helpfully.
Insti
approved these changes
Sep 24, 2018
ErikSchierboom
approved these changes
Sep 24, 2018
per exercism#1311 proper error handling object incorporated into last two test cases. wordy: lowerCased error message 2nd word per @ErikSchierboom suggestion. wordy: reworded comment to indicate 'error' per @Insti's request. wordy: error messages more helpful.
rpottsoh
force-pushed
the
updateWordy
branch
from
6ad13d9 to
86d0069
Compare
Insti
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1311 proper error handling object incorporated into last two test cases.