ocr-numbers: implement error object #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Insti
reviewed
Sep 21, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "exercise": "ocr-numbers", | |||
| "version": "1.1.0", | |||
| "version": "1.2.0", | |||
| "comments": [ | |||
| "An expectation of -1 indicates that a failure should be raised" | |||
Insti
reviewed
Sep 21, 2018
| @@ -57,7 +57,7 @@ | |||
| " " | |||
| ] | |||
| }, | |||
| "expected": -1 | |||
| "expected": {"error": "must be a multiple of four"} | |||
Insti
reviewed
Sep 24, 2018
| @@ -54,7 +54,7 @@ | |||
| " " | |||
| ] | |||
| }, | |||
| "expected": {"error": "must be a multiple of four"} | |||
| "expected": {"error": "rows must be a multiple of four"} | |||
There was a problem hiding this comment.
This doesn't match the language of the description
Insti
reviewed
Sep 24, 2018
| @@ -67,7 +67,7 @@ | |||
| " " | |||
| ] | |||
| }, | |||
| "expected": {"error": "must be a multiple of three"} | |||
| "expected": {"error": "rows must be a multiple of three"} | |||
There was a problem hiding this comment.
This has a different meaning to the description.
Insti
suggested changes
Sep 24, 2018
Insti
approved these changes
Sep 24, 2018
per exercism#1311 ocr-numbers: remove redundant comment per @Insti's suggestion. ocr-numbers: add clarity to error messages per @Insti suggestion. ocr-numbers: improved wording of error messages
rpottsoh
force-pushed
the
updateOcr-Numbers
branch
from
4327861 to
965ecad
Compare
rpottsoh
added a commit
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1311