-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format admonitions #2327
Format admonitions #2327
Conversation
e456667
to
dfe4908
Compare
CC @exercism/reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, should tracks that format files with prettier
also do this?
I checked that, with this PR, there's no more backtick-using admonition in this repo:
$ git rev-parse --short HEAD
909c8864
$ git grep --break --heading '`exercism/' -- '*.md'
$ git grep --break --heading '~exercism/' -- '*.md'
exercises/binary:search/instructions.md
8:~~~~exercism/caution
exercises/etl/instructions.md
25:~~~~exercism/note
exercises/gigasecond/introduction.md
16:~~~~exercism/note
exercises/linked:list/instructions.md
16:~~~~exercism/note
exercises/pangram/introduction.md
10:~~~~exercism/note
exercises/rational:numbers/description.md
5:~~~~exercism/note
exercises/rna:transcription/instructions.md
18:~~~~exercism/note
exercises/rna:transcription/introduction.md
7:~~~~exercism/note
exercises/secret:handshake/instructions.md
44:~~~~exercism/note
exercises/sieve/instructions.md
21:~~~~exercism/note
exercises/simple:linked-list/instructions.md
10:~~~~exercism/note
Yes. And Erik's going to do a big PR for it I believe. |
Ideally, yes I think. We could also bake this check into |
That's possible. But I think it'd be better to have an org-wide workflow that runs Thoughts? Related: exercism/configlet#562 |
That's a nice idea |
I previously created a tracking issue for it: exercism/org-wide-files#214 |
A recent commit [1] changed these to 3 backticks to reflect a commit in problem-specifications [2], but problem-specfications plans to revert the changes to admonitions [3]. [1] 3eed72b, 2023-09-19, "exercises: sync docs for 13 exercises" [2] exercism/problem-specifications@435e86aec55b [3] exercism/problem-specifications#2327
CC @exercism/reviewers Once this PR is merged, I can do the cross-repo PR. |
format-md
NPM script