Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained ajv-cli with custom script #2352

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Dec 12, 2023

closes #2283

ajv-cli is unmaintained. It gets flagged with a security vulnerability and a PR which would fix that has existed without response for close to a year.

The underlying library ajv seems to be less unmaintained. It had its last release about nine months ago.

@senekor
Copy link
Contributor Author

senekor commented Dec 12, 2023

Note on performance: yarn test-one and yarn test take almost the same amount of time (0.35 / 0.38 seconds) so I'm guessing startup of node / yarn dominates. I'd say the simple synchronous loop in the script should be fine.

@senekor
Copy link
Contributor Author

senekor commented Dec 12, 2023

CI fix in separate PR: #2353

@senekor senekor merged commit 7d01c8e into main Dec 13, 2023
7 checks passed
@senekor senekor deleted the custom-ajv-script branch December 13, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn lock has security issues
4 participants