hello-world: Change to always expect "Hello, World!" #544

rbasso · 2017-02-10T18:43:02Z

As discussed in #520, the exercise hello-world is too complex to fulfill its purpose and we decided to simplify it.

The new test suite will simply expect the string "Hello, World!", and will serve mainly as a sanity check that everything is working.

This change may disrupt some tracks that already have it implemented, so we are scheduling the merging of this PR to allow the @exercism/track-maintainers to sync track-specific changes with x-common.

The merging is tentatively scheduled to: 2016-02-20 00:01 UTC +-1 day 😄

Please direct any question/critic to #520, so that we can keep the discussion focused there.

Closes #520.

rbasso · 2017-02-10T18:46:54Z

exercises/hello-world/canonical-data.json

+    {
+      "hello":{
+        "description":"Say Hi!",
+        "expected":"Hello, World!"


There is no standard format for the canonical-data.json, so I used the one I proposed here. If by any chance it gets accepted without change, it will be one less file to update. 😄

petertseng

Thanks for taking over. It's a big effort, given that it affects new user experience for any languages that have it. Thus, all help is appreciated (I'm relieved and grateful!). You know you have my support.

A few comments.

It's tough for me to put myself in a new user's shoes anymore, since it has been too long since I was one.

petertseng · 2017-02-10T19:31:57Z

exercises/hello-world/metadata.yml

@@ -1,4 +1,4 @@
 ---
-blurb: 'Greet the user by name, or by saying "Hello, World!" if no name is given.'
+blurb: 'Just say "Hello, World!"'


Given that this exercise gets shown in e.g. http://exercism.io/languages/c/exercises , it may be nice to display prominently in this line that this is an introductory exercise.

I changed it, but I really don't know what would be good to put there.
If you have any suggestion, please write it here and I'll change it immediately.

petertseng · 2017-02-10T19:36:57Z

exercises/hello-world/description.md

-
-If a name is not given, the response should be "Hello, World!"
-
-## Test-Driven Development


Hmm. The fact that this was here makes me wonder whether it should be put into a second introductory exercise, whatever exercise is used as intro-to-TDD. Unless we think each track should deal with this.

Or, maybe we keep it here, but note that in this exercise the test suite is a single case, and in later ones it will have more cases.

I think that the instructions where misplaced.

Not all exercises implemented the hello-world exercise. Moving the instructions to leap's description.md would just reproduce the problem in another place.

The immediate solution I can think of is track-dependent: Move it to the HINTS.md from the first exercise that is not hello-world. This is more flexible than forcing it to be leap.

This way, each track can customize the instructions to reflect what are the best practices for testing in the language. Not all languages are so TDD focused as ruby seems to be, specially the strongly-typed ones, that force users to type-check everything before running a single test.

I just create a Gist of a HINTS.md file with the old instructions here, to make migration easier. If you think this is a good idea, we could link it in a more visible place to help the track maintainers.

I agree that the instrutions were misplaced. Languages can use the proposed hint for their next exercise, whatever it may be.

Dispader · 2017-02-16T01:04:25Z

exercises/hello-world/description.md

-readable as we can. However, solutions to the hello-world exercise will not be
-reviewed by a person, but by rikki- the robot, who will offer an encouraging
-word.
+If everything goes well, you will be ready to fetch your first real exercise.


Very nice. One note (probably to myself): while the instructions we lose in this Pull seem appropriate to remove here, they might be useful somewhere else. If we do end up choosing a intro-to-tdd exercise, this might be a good source for that description.md.

ErikSchierboom · 2017-02-16T11:55:14Z

exercises/hello-world/description.md


-    exercism skip $TRACK_ID hello-world
+- Write a function that says "Hello, World!".
+- Run the tests and make sure that they succeed.


Maybe "Run the tests" should be "Run the test(s)", as I expect most languages to only have a single test.

Run the test file? This is always the case, unless there are tracks with multiple files for testing?

"Run the test suite..." ?

Run the test suite is a very nice suggestion! I like that.

rbasso · 2017-02-20T04:34:23Z

The time for merging has come (in fact we are 4 hours and 30 minutes late), so I'm merging this as promised/agreed and hope that all the tracks also merge their changes soon, to keep consistency

The merging is tentatively scheduled to: 2016-02-20 00:01 UTC +-1 day 😄

This is in line with exercism/problem-specifications#544

see exercism/problem-specifications#544

* hello-world: Change to always expect "Hello, World!" see exercism/problem-specifications#544 * hello-world: add stub file

by always expecting "Hello, World!" Change in x-common: [here](exercism/problem-specifications#544) Upcoming new exercise to kinda replace `hello-world`: [here](exercism/problem-specifications#759) Since this `hello-world` is just meant to be a sanity check for everything working, I also went ahead and removed the use of class for the sake of simplicity. We can introduce classes with the next `two-fer` exercise.

rbasso commented Feb 10, 2017

View reviewed changes

petertseng reviewed Feb 10, 2017

View reviewed changes

petertseng approved these changes Feb 11, 2017

View reviewed changes

Dispader reviewed Feb 16, 2017

View reviewed changes

Dispader mentioned this pull request Feb 16, 2017

hello-world: Change to always expect "Hello, World!" exercism/groovy#38

Merged

ErikSchierboom reviewed Feb 16, 2017

View reviewed changes

SaschaMann mentioned this pull request Feb 16, 2017

hello-world: Update to fit the new canonical data exercism/julia#47

Merged

ErikSchierboom approved these changes Feb 17, 2017

View reviewed changes

hello-world: Change to always expect "Hello, World!"

35aa16b

rbasso merged commit feef23e into exercism:master Feb 20, 2017

rbasso deleted the hello-world-simplified branch February 20, 2017 04:44

NobbZ pushed a commit to NobbZ/exercism-erlang that referenced this pull request Feb 20, 2017

[hello-world] update to current version of canonical data

635629a

This is in line with exercism/problem-specifications#544

NobbZ mentioned this pull request Feb 20, 2017

[hello-world] update to current version of canonical data exercism/erlang#139

Merged

NobbZ added a commit to exercism/erlang that referenced this pull request Feb 20, 2017

[hello-world] update to current version of canonical data (#139)

397ecb6

This is in line with exercism/problem-specifications#544

robphoenix mentioned this pull request Feb 20, 2017

Test versioning exercism/lua#192

Closed

robphoenix added a commit to robphoenix/exercism-lua that referenced this pull request Feb 21, 2017

hello-world: Change to always expect "Hello, World!"

1ad5648

see exercism/problem-specifications#544

robphoenix mentioned this pull request Feb 21, 2017

hello-world: update to new x-common canonical-data exercism/lua#193

Merged

ryanplusplus pushed a commit to exercism/lua that referenced this pull request Feb 21, 2017

hello-world: update to new x-common canonical-data (#193)

4f7ba32

* hello-world: Change to always expect "Hello, World!" see exercism/problem-specifications#544 * hello-world: add stub file

tejasbubane mentioned this pull request Apr 18, 2017

Make hello-world more simple exercism/javascript#273

Merged

joseph-walker mentioned this pull request Apr 20, 2017

Updates Hello-World exercise skeleton and test spec. exercism/php#154

Merged

petertseng mentioned this pull request Oct 27, 2017

Don't assume two-fer is the second exercise. #949

Closed

ttnagata mentioned this pull request Nov 15, 2017

hello-world: Test do not match README.md exercism/r#82

Closed

haus mentioned this pull request Feb 18, 2018

Hello, World! exercise has an old ReadMe exercism/clojure#215

Closed

ee7 mentioned this pull request Feb 8, 2019

hello-world: Update tests and example to 1.1.0, and rename test file exercism/nim#132

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hello-world: Change to always expect "Hello, World!" #544

hello-world: Change to always expect "Hello, World!" #544

rbasso commented Feb 10, 2017 •

edited

Loading

rbasso Feb 10, 2017

petertseng left a comment •

edited

Loading

petertseng Feb 10, 2017

rbasso Feb 11, 2017

petertseng Feb 10, 2017

rbasso Feb 11, 2017

ErikSchierboom Feb 11, 2017

Dispader Feb 16, 2017

ErikSchierboom Feb 16, 2017

kotp Feb 16, 2017

rbasso Feb 17, 2017

ErikSchierboom Feb 17, 2017

rbasso commented Feb 20, 2017


		If a name is not given, the response should be "Hello, World!"

		## Test-Driven Development

hello-world: Change to always expect "Hello, World!" #544

hello-world: Change to always expect "Hello, World!" #544

Conversation

rbasso commented Feb 10, 2017 • edited Loading

Choose a reason for hiding this comment

petertseng left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbasso commented Feb 20, 2017

rbasso commented Feb 10, 2017 •

edited

Loading

petertseng left a comment •

edited

Loading