Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfect-numbers: add canonical data #611

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

stkent
Copy link
Contributor

@stkent stkent commented Feb 26, 2017

Closes #575. See that issue for background information. Please contribute any new comments in this PR. Thanks!

I attempted to follow the proposed canonical data spec from #602. If you spot any deviations from the proposal, please let me know and I can correct them. cc @rbasso for his expertise and validation 😄 [One thing I was unsure of: whether it is expected that inputs/outputs always be strings, or whether other data types (as used for inputs here) are permitted by that spec.]

@stkent stkent force-pushed the perfect-numbers-canonical-data branch from 46cf16a to a451dc6 Compare February 26, 2017 02:06
Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't followed the discussion about the tests' contents, so I'm reviewing just the format.

I attempted to follow the proposed canonical data spec from #602.

Nice to see the schema being used. 😄

If you spot any deviations from the proposal, please let me know and I can correct them. cc @rbasso for his expertise and validation 😄

I just validated the canonical-data.json file here, so it is formally correct.

...[One thing I was unsure of: whether it is expected that inputs/outputs always be strings, or whether other data types (as used for inputs here) are permitted by that spec.]

description, property and error need to be string, other values can be anything. In this case, representing yourinput values as numbers seems a perfect choice. 👍

@stkent
Copy link
Contributor Author

stkent commented Feb 26, 2017

@rbasso thanks for the checks and confirmations; I had not seen the schema lint site before, that's really neat!

@ErikSchierboom ErikSchierboom merged commit 19d0c77 into master Feb 28, 2017
@ErikSchierboom
Copy link
Member

Great work @stkent! 🎉

@stkent stkent deleted the perfect-numbers-canonical-data branch February 28, 2017 15:26
@stkent
Copy link
Contributor Author

stkent commented Feb 28, 2017

Thanks!

emcoding pushed a commit that referenced this pull request Nov 19, 2018
tests: Check in the correct location for the example file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants