Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circular-buffer: Make exercise schema-compliant. #681

Merged
merged 1 commit into from
Mar 10, 2017
Merged

circular-buffer: Make exercise schema-compliant. #681

merged 1 commit into from
Mar 10, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Mar 10, 2017

Related to #625.

petertseng
petertseng approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how this would happen, whether the operations would all have to be encoded as something else, but I the issue has been sidestepped.

@rbasso rbasso mentioned this pull request Mar 10, 2017
Closed
75 tasks
@rbasso rbasso merged commit 6ee77c8 into exercism:master Mar 10, 2017
@rbasso rbasso deleted the circular-buffer-schema branch March 10, 2017 10:11
@petertseng petertseng mentioned this pull request Nov 18, 2018
Merged
petertseng added a commit to exercism/rust that referenced this pull request Nov 18, 2018
@petertseng
circular-buffer 1.1.0 (#737)
6ff047f 
The tests are the same as the initial unversioned version of canonical-data:
exercism/problem-specifications#488

This is because all subsequent changes did not change test content:

1.0.0 (formatting change only):
exercism/problem-specifications#681
1.0.1 (clarify overwrite):
exercism/problem-specifications#892
1.1.0 (move inputs to `input` object):
exercism/problem-specifications#1186

The Rust track already had most of the tests; these mostly add some
clarity around `clear` and addds a test for an `overwrite` following a
`read`.
emcoding pushed a commit that referenced this pull request Nov 19, 2018
closes #681
b4b8683 
+ Edit GETTING_STARTED.md to remove references to multiple tests since
there is only one test in the suite.

+ Add RUNNING_TESTS.md, which includes instructions for running multiple
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertseng petertseng petertseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbasso @petertseng