Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublist: Make exercise schema-compliant #705

Merged
merged 3 commits into from
Mar 11, 2017
Merged

sublist: Make exercise schema-compliant #705

merged 3 commits into from
Mar 11, 2017

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Mar 11, 2017

Related to #625.

@petertseng
Copy link
Member

petertseng commented Mar 11, 2017

Surprise!

expectation -> expected please.

The only file to do that.

Well, okay, I guess expected isn't required for compliance... but it would probably be better to use that, yes?

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I'll tell you what, if you really want to stick with expectation and change it later, you still have my support

@rbasso
Copy link
Contributor Author

rbasso commented Mar 11, 2017

I'm considering changing to expectation and also change the other two keys to camelCase, to conform with the Google JSON Style. What do you think about it?

@petertseng
Copy link
Member

I'm considering changing to expectation

Good!

and also change the other two keys to camelCase

Seems good too! You also did it in rotational-cipher so why not here too!

rbasso added 2 commits March 11, 2017 20:52
Change key names:

 - 'expectation' -> 'expected', which is an informal standard
 - 'list_one'    -> 'listOne'
 - 'list_two'    -> 'listTwo'

These last two changes are to follow the Google JSON Style Guide,
which recommends camelCase for key names.
@rbasso
Copy link
Contributor Author

rbasso commented Mar 11, 2017

Updated!

@rbasso
Copy link
Contributor Author

rbasso commented Mar 11, 2017

The last commit (the only one hard to review) should be just formatting.

@rbasso rbasso merged commit 9c2430a into exercism:master Mar 11, 2017
@rbasso rbasso deleted the sublist-schema branch March 11, 2017 11:59
@petertseng
Copy link
Member

I review commits that claim to be formatting-only with git log -p -w

Plus a small script to fetch arbitrary PRs:

#!/bin/sh

# remote of current branch is...
remotebranch=$(git rev-parse --abbrev-ref --symbolic-full-name @{u})
remote=$(echo "$remotebranch" | cut -d/ -f1)
echo "remote: $remote"

if [ $# -lt 2 ]; then
  echo "usage: $0 PR localbranch"
  exit 1
fi

git fetch $remote refs/pull/$1/head:$2

git pr 705 sublist

@rbasso
Copy link
Contributor Author

rbasso commented Mar 11, 2017

Thanks! I'll try that later.

emcoding pushed a commit that referenced this pull request Nov 19, 2018
Add default introductory code example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants