-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sublist: Make exercise schema-compliant #705
Conversation
Surprise! expectation -> expected please. The only file to do that. Well, okay, I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I'll tell you what, if you really want to stick with expectation
and change it later, you still have my support
I'm considering changing to |
Good!
Seems good too! You also did it in rotational-cipher so why not here too! |
Change key names: - 'expectation' -> 'expected', which is an informal standard - 'list_one' -> 'listOne' - 'list_two' -> 'listTwo' These last two changes are to follow the Google JSON Style Guide, which recommends camelCase for key names.
Updated! |
The last commit (the only one hard to review) should be just formatting. |
I review commits that claim to be formatting-only with Plus a small script to fetch arbitrary PRs: #!/bin/sh
# remote of current branch is...
remotebranch=$(git rev-parse --abbrev-ref --symbolic-full-name @{u})
remote=$(echo "$remotebranch" | cut -d/ -f1)
echo "remote: $remote"
if [ $# -lt 2 ]; then
echo "usage: $0 PR localbranch"
exit 1
fi
git fetch $remote refs/pull/$1/head:$2
|
Thanks! I'll try that later. |
Add default introductory code example
Related to #625.