bracket-push: add a test case #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
approved these changes
Apr 6, 2017
|
Thanks, test seems good can we have bracket-push in the commit message as https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#pull-request-guidelines requests? can we have version 1.1.0 since it falls under https://github.com/exercism/x-common/blob/master/README.md#minor-version-changes |
|
can we have imperative mood in the commit message: https://chris.beams.io/posts/git-commit/#imperative |
|
Will do |
lex57ukr
changed the title
|
All done. Thanks for your feedback! |
petertseng
approved these changes
Apr 6, 2017
|
Musing to myself - we might consider whether some of the later cases in this file are made unnecessary by this case. I don't know what kinds of incorrect implementations people might come up with though. |
petertseng
added a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Apr 8, 2017
wrong closing bracket for the opening bracket exercism/problem-specifications#747
behrtam
added a commit
to exercism/python
that referenced
this pull request
Apr 27, 2017
Adds a new test case to cover broken stack-based implementations. see: exercism/problem-specifications#747
petertseng
added a commit
to exercism/rust
that referenced
this pull request
May 13, 2017
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
sum-of-multiples: regenerate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps cover broken stack-based implementations