Ignore bonus tests #37
Conversation
| @@ -0,0 +1,33 @@ | |||
| pending :- | |||
| current_prolog_flag(argv, ['--all'|_]). | |||
| pending :- | |||
There was a problem hiding this comment.
I believe you'll have to add a similar mechanism for bonus as used in pending.
Although it appears to be better options to block tests: https://www.swi-prolog.org/pldoc/man?section=unitbox
Using blocked for example, I'll look into it for a proper suggestion.
There was a problem hiding this comment.
Hello there again, so after checking the reference, same link as above, we're correctly using condition(I wasn't on my PR).
We would have to replicate a similar mechanism to pending or redesign this, we could have a composite for the pending conditions.
Condition is unique and can only take an atom, thus something like condition(pending, bonus) wouldn't work, but we could just have condition(bonus) for the bonus clause.
I'm going to find some time after work to look further into this, for a better solution.
I'll use my PR on triangle as a POC(exercism/prolog#289)
There was a problem hiding this comment.
@ErikSchierboom Just updated the other PR (exercism/prolog#289) with the same mechanism as pending, please do check it.
There was a problem hiding this comment.
That works! Great.
exercism/prolog#289 aims to introduce some optional bonus tests. We should make sure that the test runner ignores these when running the tests.