improvement on complex-numbers tests #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While mentoring at exercism, i saw someone came up with a "solution" to complex-numbers that made absolutely no sense, but still passed all tests. I believe this was on purpose but he hasen't confirmed that yet.
This is the code he uploaded:
This passes the tests because they only check if the program recognize valid solutions for
add
sub
... etc. But not if its able to find those solutions. And in case ofabs
, because it only has tests with 5 as a result.I believe I've fixed both cases.