Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leap exercise #8

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Add leap exercise #8

merged 2 commits into from
Dec 9, 2016

Conversation

lpil
Copy link
Member

@lpil lpil commented Dec 8, 2016

No description provided.

@paf31
Copy link
Contributor

paf31 commented Dec 8, 2016

👍 Looks good!

@paf31
Copy link
Contributor

paf31 commented Dec 8, 2016

@kytrinyx Once Travis is updated (#9), shall I just merge these if the tests pass and the code looks right?

@kytrinyx
Copy link
Member

kytrinyx commented Dec 9, 2016

@paf31 Yeah, totally!

lpil added 2 commits December 9, 2016 19:55
We don't provide these in the Elm track, so it seems sensible not to do
it here either.
@lpil
Copy link
Member Author

lpil commented Dec 9, 2016

Rebased, tests are green :)

@@ -1,6 +1 @@
module HelloWorld where

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed, out of curiosity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the tracks for Haskell and Elm and saw that they didn't provide the typesig so I stopped providing them too. HelloWorld was made before I realised this so I'm removing it to match the others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@paf31 paf31 merged commit 2f2ba39 into exercism:master Dec 9, 2016
@paf31
Copy link
Contributor

paf31 commented Dec 9, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants