Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runner Fixes]: Updated Docker Image to use Alpine & Fixed Stdout Reporting #114

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Oct 4, 2023

Closes issue #67

  • Changed Docker image to use python:3.11.5-alpine3.18
  • Changed /bin/run.sh, /bin/run-in-docker.sh, and /bin/run-tests-in-docker.sh to use python:3.11.5-alpine3.18 python paths.
  • Upgraded pytest-subtests to version 0.11
  • Per this Discord thread as well as this long-standing GH issue 67, removed u character that denoted subtests from stdout (printed) content, and modified runner to parse and place subtest stdout with each subtest in the results.json, rather than with the parent test output field.
  • Added the example-partial-failure-with-subtests-and-stdouttest to verify the fix for u removal and stdout placement.
  • Updated/modified the following tests and results.json files to account for the use of Alpine/Python 3.11.5, pytest-subtests 0.11, and the new runner modifications:
    • test/example-has-stdout-and-tasks/example_has_stdout_and_tasks_test.py
    • test/example-has-stdout/example_has_stdout.py
    • test/example-has-stdout/example_has_stdout_test.py
    • test/example-all-fail-tasks-and-subtests/results.json
    • test/example-has-stdout-and-tasks/results.json
    • test/example-has-stdout-tasks-and-subtests/results.json
    • test/example-has-stdout/results.json
    • test/example-partial-failure-with-subtests-and-stdout/results.json
    • test/example-partial-failure-with-subtests/results.json
    • test/example-syntax-error/results.json

@BethanyG
Copy link
Member Author

BethanyG commented Oct 4, 2023

Intended to also change the CI to run the Python repo tests, but will do that in a separate PR.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BethanyG
Copy link
Member Author

BethanyG commented Nov 7, 2023

Crossing fingers 🤞🏽 and pushing the big, green button! 🌟

@BethanyG BethanyG merged commit c6ecb10 into exercism:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants