Travis CI build is failing across the board... somewhat mysteriously

[kytrinyx]

Since it started happening consistently and quite suddenly, I wonder if something changed on Travis CI's end with how they set up the environment.

If someone has a moment to dig into what's going on, that would be great.

[kytrinyx]

Ah. See discussion in #285 -- @oalbe has a suggestion. I'll give it a try.

[petertseng]

I dug into it and have the explanation for what's going on (which is interesting to me since I have a PR open and flask is blocking it), but I'm not stylistically opinionated enough to decide how to fix it (either do what the violations direct, or ignore them), so I leave that up to y'all.

[kytrinyx]

Ah, OK, that explanation makes senes. Yeah, I don't have any strong opinions on this (not being a python dev, and all).

[behrtam]

it's a good idea to only make use of lambda to use a function without assigning it, like:

sorted(data, key=lambda item: item.score)

[behrtam]

I have no experience with continuous integration. We could change the travis-ci config, to work with a fixed flake8 version pip install flake8==2.5.1 so we don't break builds without changing anything, only because there is a new flake8 version. The down side is, that we would need to upgrade the travis-ciconfig every time we want to use a new version of flake8 (shouldn't happen too often).

[kytrinyx]

If it's not something that happens too often, I think it's worth it to just change the travis-ci configuration (.travis.yml).

[petertseng]

1. Short term: Thanks for dealing with this; other PRs are good to go once they rebase (I know because I rebased mine and it's good)
2. Long term: Pinning versions would indeed help prevent things like this; y'all would have to periodically check for new versions as y'all deem appropriate. Note that you would want to pin at least pep8 in addition to flake8. Probably also pyflakes too. Reasoning being that flake8 hasn't changed since December 30 2015 and yet things still broke in here; it was pep8 that changed.

[behrtam]

flake8 changed their pinning from "pep8 >= 1.5.7, < 1.6" in 2.4 to "pep8 >= 1.5.7, != 1.6.0, != 1.6.1, != 1.6.2" in 2.5. They basically decided against pinning (Issue).
So I think we should pin down all the versions.