wordy: update tests to v1.2.0 #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Oct 1, 2018
exercises/wordy/wordy_test.py
Outdated
| @@ -51,12 +51,14 @@ def test_multiple_division(self): | |||
| calculate("What is -12 divided by 2 divided by -3?"), 2) | |||
|
|
|||
| def test_unknown_operation(self): | |||
| with self.assertRaisesWithMessage(ValueError): | |||
| with self.assertRaisesWithMessage(ValueError) as error: | |||
There was a problem hiding this comment.
In this track, we don't test for actual exception message content, only that one is present. The reasoning for this is summarized well here: #1080 (comment)
There was a problem hiding this comment.
Ok. Well should i check that the error message is not empty? Or is raising an error enough?
There was a problem hiding this comment.
assertRaisesWithMessage checks for a non-null, non-empty error message.
Spacing arround reference fixed
cmccandless
approved these changes
Oct 1, 2018
|
Merged; thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update wordy test to 1.2.0. Fix #1530