-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Template Error, regenerated tests for Flattened Problem Specs #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyG
changed the title
Fixed error in template for acronym, regenerated tests for acronym.
Fixed Template Error, regenerated tests for Flattened Problem Specs
May 10, 2021
Flagging this as major, because of the troubleshooting and trial-and-error involved in fixing it. |
cmccandless
approved these changes
May 10, 2021
(Reapplied the label for you) |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how the problem slipped in, but it appears that the footer include for the acronym JinJa template was missing aTrue
and was generating an empty test file....or at least that's what appeared to be happening....As a result of PR#1798, the following exercises needed to have edits made to their JinJa2 Templates to remove the second
case
level. Then test files needed to be regenerated.Exercises:
Additionally,
trinary
,pascals-triangle
,micro-blog
, andnucleotide-count
were changed by the PR but no changes were needed for Python --micro-blog
is not implemented, and the rest do not have JinJa2 templates.