Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Template Error, regenerated tests for Flattened Problem Specs #2421

Merged
merged 22 commits into from
May 10, 2021

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented May 9, 2021

Don't know how the problem slipped in, but it appears that the footer include for the acronym JinJa template was missing a True and was generating an empty test file....or at least that's what appeared to be happening....

As a result of PR#1798, the following exercises needed to have edits made to their JinJa2 Templates to remove the second case level. Then test files needed to be regenerated.

Exercises:

  • acronym
  • alphametics
  • book-store
  • etl
  • food-chain
  • gigasecond
  • house
  • isogram
  • ocr-numbers
  • perfect-numbers
  • phone-number
  • prime-factors
  • protein-translation
  • rotational-cipher
  • secret-handshake

Additionally, trinary, pascals-triangle, micro-blog, and nucleotide-count were changed by the PR but no changes were needed for Python -- micro-blog is not implemented, and the rest do not have JinJa2 templates.

@BethanyG BethanyG requested a review from a team as a code owner May 9, 2021 05:37
@BethanyG BethanyG changed the title Fixed error in template for acronym, regenerated tests for acronym. Fixed Template Error, regenerated tests for Flattened Problem Specs May 10, 2021
@BethanyG
Copy link
Member Author

Flagging this as major, because of the troubleshooting and trial-and-error involved in fixing it.

@BethanyG BethanyG merged commit 40eec70 into exercism:main May 10, 2021
@iHiD iHiD added the x:size/large Large amount of work label Sep 28, 2021
@iHiD
Copy link
Member

iHiD commented Sep 28, 2021

(Reapplied the label for you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants