Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings Concept Exercise Re-Write #2433

Merged
merged 16 commits into from
May 29, 2021
Merged

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented May 19, 2021

Renamed exercises from processing-logs to little-sisters-vocab
Added <str>.join(), <>.split(), string indexes, and string slices to the exercise.

  • Edited config.json for exercise rename.
  • Rewrote introduction.md
  • Rewrote instructions.md
  • Rewrote hints.md
  • Rewrote exemplar.py
  • Rewrote strings_test.py
  • Added docstrings to strings.py
  • Edited /.meta/links.json file
  • Added exercise icon to .meta/config.json file
  • Formatted .meta/config.json file

@BethanyG BethanyG requested a review from a team as a code owner May 19, 2021 03:03
@BethanyG BethanyG requested a review from cmccandless May 19, 2021 03:04
@BethanyG BethanyG requested review from a team and removed request for cmccandless May 28, 2021 18:51
@neenjaw neenjaw self-requested a review May 29, 2021 01:58
Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of optimistic merging, I think this is quite good. There are a few changes I would suggest to wording/grammar. Nice work @BethanyG!!

config.json Outdated Show resolved Hide resolved
exercises/concept/little-sisters-vocab/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/little-sisters-vocab/.docs/hints.md Outdated Show resolved Hide resolved
@neenjaw
Copy link
Contributor

neenjaw commented May 29, 2021

@exercism/reviewers was pinged to this, so I assumed could approve it, but 🤷🏻 (@iHiD)

@SleeplessByte
Copy link
Member

You can. It's approved now

BethanyG and others added 4 commits May 29, 2021 12:57
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Suggestions/corrections/edits from code review.

Co-authored-by: Tim Austin <tim@neenjaw.com>
@BethanyG
Copy link
Member Author

@SleeplessByte -- it's not. At least, I am not seeing it. I am seeing the below. So I think the codeowners file needs to be changed, or permissions need to be re-jiggered??.:

image

@SleeplessByte
Copy link
Member

Ah yes. A python member needs to approve it!

@SleeplessByte
Copy link
Member

https://github.com/orgs/exercism/teams/python/members

@exercism/python We need you!

added three step examples per suggestions on code review.
@iHiD
Copy link
Member

iHiD commented May 29, 2021

I've removed the codeowners restriction. It doesn't really make much sense to have it there as this should be managed by GH teams. I'd suggest only having it on specific things you want to ensure have two track-maintainers agree on something, for example workflows on the Javascript track.

I've also removed it on the Tooling repos, which had you and Corey hard-coded as having to sign off each others work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants