-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings Concept Exercise Re-Write #2433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the spirit of optimistic merging, I think this is quite good. There are a few changes I would suggest to wording/grammar. Nice work @BethanyG!!
@exercism/reviewers was pinged to this, so I assumed could approve it, but 🤷🏻 (@iHiD) |
You can. It's approved now |
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Co-authored-by: Tim Austin <tim@neenjaw.com>
Suggestions/corrections/edits from code review. Co-authored-by: Tim Austin <tim@neenjaw.com>
@SleeplessByte -- it's not. At least, I am not seeing it. I am seeing the below. So I think the codeowners file needs to be changed, or permissions need to be re-jiggered??.: |
added escape character example.
Ah yes. A python member needs to approve it! |
https://github.com/orgs/exercism/teams/python/members @exercism/python We need you! |
added three step examples per suggestions on code review.
I've removed the codeowners restriction. It doesn't really make much sense to have it there as this should be managed by GH teams. I'd suggest only having it on specific things you want to ensure have two track-maintainers agree on something, for example workflows on the Javascript track. I've also removed it on the Tooling repos, which had you and Corey hard-coded as having to sign off each others work. |
Renamed exercises from
processing-logs
tolittle-sisters-vocab
Added
<str>.join()
,<>.split()
, string indexes, and string slices to the exercise.config.json
for exercise rename.introduction.md
instructions.md
hints.md
exemplar.py
strings_test.py
strings.py
/.meta/links.json
file.meta/config.json
file.meta/config.json
file