-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meltdown exercise change according to issue #2565 #2568
Conversation
Changes: - Change Task 2 intervals to cover non-integer comparison. - Rewrite tests to test more points, especially the border cases. - Reduce number of tests of only one per function, but test many points (asserts in loop) in each test. - Remove hints of integer input parameters (they can be any numeric type).
Remove python 3.8 debug f-string syntax for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbuc -- These are excellent changes. Thank you. 😄 I have one language suggestion (which is optional) and a request about tests/variations. Let me know if you have any questions or issues.
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Oh! And I almost forgot (which is terrible) -- please add a |
The parameter types can be either integers or floats. This is hinted with the Union type familiar with most of the current python users. (Can be replaced with | in the future and/or moved to :type: field of the docstring.)
@IsaacG -- Please don't recommend anything from |
Bumping this to |
Changes:
(asserts in loop) in each test.