Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meltdown exercise change according to issue #2565 #2568

Merged
merged 7 commits into from
Sep 17, 2021

Conversation

kbuc
Copy link
Contributor

@kbuc kbuc commented Sep 10, 2021

Changes:

  • Change Task 2 intervals to cover non-integer comparison.
  • Rewrite tests to test more points, especially the border cases.
  • Reduce number of tests of only one per function, but test many points
    (asserts in loop) in each test.
  • Remove hints of integer input parameters (they can be any numeric type).

Changes:
- Change Task 2 intervals to cover non-integer comparison.
- Rewrite tests to test more points, especially the border cases.
- Reduce number of tests of only one per function, but test many points
  (asserts in loop) in each test.
- Remove hints of integer input parameters (they can be any numeric type).
Remove python 3.8 debug f-string syntax for backwards compatibility.
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbuc -- These are excellent changes. Thank you. 😄 I have one language suggestion (which is optional) and a request about tests/variations. Let me know if you have any questions or issues.

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG
Copy link
Member

Oh! And I almost forgot (which is terrible) -- please add a contributors key to the config for this exercise, and then add yourself to the array. 😄 exercise config.json, so that you get credit for all the work you've done on this re-write. Here is the spec for that config.json file.

The parameter types can be either integers or floats. This is
hinted with the Union type familiar with most of the current python users.
(Can be replaced with | in the future and/or moved to :type: field of
the docstring.)
@BethanyG
Copy link
Member

@IsaacG -- Please don't recommend anything from typing in concept exercises or concept exercise docstrings that don't have typing as a prerequisite. We don't want to confuse students or require an optional module for a concept exercise. Thanks!

@BethanyG BethanyG added the x:size/large Large amount of work label Sep 17, 2021
@BethanyG
Copy link
Member

Bumping this to large size given the back and forth with test cases and language. @kbuc -- many thanks for your patience with the process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants