[Cater-Waiter]: Reduced the Overall Number of Set Tests to 82 #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J08K
reviewed
Sep 29, 2021
| @@ -12,7 +12,8 @@ | |||
|
|
|||
| from sets_categories_data import (VEGAN, | |||
| VEGETARIAN, | |||
| KETO, PALEO, | |||
There was a problem hiding this comment.
Yep, this was really important! XD
J08K
approved these changes
Sep 29, 2021
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (we hope!) #2504
Reduced the number of tests by using slices to pick every second (or in some cases third) item in the test data, thereby cutting the tests by 50% or 60%. While this makes the tests less easy to read, it avoids hours of hand-reducing the big test data file, and can easily be modified to add or subtract cases.
Also did some small cleanups on the test data file itself. With any luck, this solves our PyLInt whiney problem. We'll need to test that on the website though.