[New Workflow]: Added snippets to the auto-pr-commenter. 2/2 #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyG
changed the title
kotp
reviewed
Oct 30, 2021
|
Ok. I think I got all those edits! LMK if I didn't. This was a weird one. I had to resort to using VIM to edit the file -- PyCharm would not save the edits, and git would not pick them up. It was very strange. |
|
Ok. I **think** I got all those edits! LMK if I didn't. This was a
weird one. I had to resort to using VIM to edit the file
I will check the patch file, but yes, VIM does the right thing on save
for text files, by default.
|
|
@kotp -- does that mean this is ready -- or are there still things to be addressed? Let Me Know. Thanks! |
SaschaMann
approved these changes
Oct 30, 2021
|
@kotp -- if there is nothing more to address, please approve so I can merge this and the follow-on PR. Many thanks! |
verdammelt
approved these changes
Oct 30, 2021
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new PR-Commenter for the repo, codename:
Porcupine Revenger. Made together with @J08K ❤️Splitting this into two parts, for sharing of REP purposes.
MERGE FIRST PLEASE